Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10046/fix/question char not searchable fixed #10099

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ronibhakta1
Copy link
Contributor

@ronibhakta1 ronibhakta1 commented Nov 28, 2024

Closes #10046
Ok as you told me to do some tests on solr, i have taken some references from previous issue fix and made some changes as required in codebase and i have done the tests.
@cdrini just try to run it on your end once

Support for "?" search as a string

Technical

Fix in the solr check and all other constrains to get overcome though all other previous done by other contributor in 2023, there are were some issues with the "?" search which has a different behavior which helps to search

Screenshot

Testing

"hello?" as a string
Screenshot 2024-11-28 at 6 41 37 AM

"? hello? world" as a string
Screenshot 2024-11-28 at 6 57 12 AM

"hello? world" as a string
Screenshot 2024-11-28 at 6 57 16 AM

"?" as a string
Screenshot 2024-11-28 at 6 27 56 AM

Stakeholders

@ronibhakta1
Copy link
Contributor Author

@cdrini have you checked the updates?

@cdrini
Copy link
Collaborator

cdrini commented Dec 24, 2024

Awesome, thanks for revising @ronibhakta1 ! Hmm, the results there don't quite look correct; in your screenshot, it seems like the WDGF is converting "?" to nothing! So the search will still not work. This one might be a bit more hairy ; also are you sure you reset your environment after making the changes to the manage-schema ? I.e.

docker compose down
docker volume rm openlibrary_solr-data_1 openlibrary_solr-updater-data_1  # I think these are the right volumes; double check by running `docker volume ls`
docker compose up -d

Another way to test is to create a book on your local open library to e.g. set the title as ? , and then you can check if it shows up in search.

Let me know if you have any other questions 👍

@cdrini cdrini added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Dec 24, 2024
@ronibhakta1
Copy link
Contributor Author

Awesome, thanks for revising @ronibhakta1 ! Hmm, the results there don't quite look correct; in your screenshot, it seems like the WDGF is converting "?" to nothing! So the search will still not work. This one might be a bit more hairy ; also are you sure you reset your environment after making the changes to the manage-schema ? I.e.

docker compose down
docker volume rm openlibrary_solr-data_1 openlibrary_solr-updater-data_1  # I think these are the right volumes; double check by running `docker volume ls`
docker compose up -d

Another way to test is to create a book on your local open library to e.g. set the title as ? , and then you can check if it shows up in search.

Let

I will check with those and connect with you after running some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

? character is not searchable
2 participants